Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Date: Wed, 14 Nov 2012 13:50:12 +0000 (UTC)
From: =?utf-8?Q?Olivier_Lamy_=28*=24=5E=C2=A8=25=60=C2=A3=29_=28JIRA=29?=
 <jira@apache.org>
To: dev@tomcat.apache.org
Message-ID: <753919279.113848.1352901012307.JavaMail.jiratomcat@arcas>
In-Reply-To: <558564329.113704.1352899333339.JavaMail.jiratomcat@arcas>
Subject: [jira] [Comment Edited] (MTOMCAT-185) change phase for
 tomcat6/7:run to process-classes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MTOMCAT-185?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D134=
97100#comment-13497100 ]=20

Olivier Lamy (*$^=C2=A8%`=C2=A3) edited comment on MTOMCAT-185 at 11/14/12 =
1:48 PM:
--------------------------------------------------------------------------

Yup I agree it's a better phase especially for your use case :-)
So I change that.
NOTE you can test snapshot following instructions from here: http://tomcat.=
apache.org/maven-plugin-2.1-SNAPSHOT/snapshot-test.html
               =20
      was (Author: olamy):
    Yup I agree it's a better phase especially for your use cad :-)
So I change that.
                 =20
> change phase for tomcat6/7:run to process-classes
> -------------------------------------------------
>
>                 Key: MTOMCAT-185
>                 URL: https://issues.apache.org/jira/browse/MTOMCAT-185
>             Project: Apache Tomcat Maven Plugin
>          Issue Type: Bug
>          Components: tomcat7
>    Affects Versions: 2.0
>            Reporter: Jiri Peinlich
>            Assignee: Olivier Lamy (*$^=C2=A8%`=C2=A3)
>              Labels: maven, newbie
>             Fix For: 2.1
>
>
> Hello,=20
> I do not know enough about maven+tomcat and related technologies to know =
if the following is bug, or if I just missed some setting somewhere.=20
> We have in our project dependencies, that inject some byte-code into comp=
iled classes in the process-classes maven phase. I was trying to use maven =
 tomcat7 plugin in version 2.0 to see how is our application working. When =
executing mvn tomcat7:run i run into problems because the maven phase proce=
ss-classes was not executed before deploying on tomcat.=20
> After some research we found that there is plugin.xml file in the tomcat7=
 plugin jar that maven downloads (org.apache.tomcat.maven.tomcat7-maven-plu=
gin) (META_INF/maven/plugin.xml). In this file i found mojo with <goal>run<=
/goal> and in this mojo there i found <executePhase>compile</executePhase>.=
 I think that the execution phase should be set to process-classes phase an=
d not compile phase.
> My problems disappeared When I manually edited the xml and tried the mvn =
tomcat7:run afterwards. This makes me think that the phase is wrongly set i=
n the jar.=20
> I checked the sources and to me it seams that the phase should be set her=
e:
> http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plug=
in/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java?vi=
ew=3Dmarkup
> The execution phase is set there to be compile (curretnly line 60)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org