Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <50ACD962.10602@christopherschultz.net>
Date: Wed, 21 Nov 2012 08:38:42 -0500
From: Christopher Schultz <chris@christopherschultz.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8;
 rv:16.0) Gecko/20121026 Thunderbird/16.0.2
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: [VOTE] Release Apache Tomcat 7.0.33
References: <50A97070.4070907@apache.org>
In-Reply-To: <50A97070.4070907@apache.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigB9E6FA51AF255E1F09D74F4E"

--------------enigB9E6FA51AF255E1F09D74F4E
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Mark,

On 11/18/12 6:34 PM, Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.33 release is now available for voting.
>=20
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.33/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-043/=

> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_33/
>=20
> The proposed 7.0.33 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.33 Stable

Not sure if my vote is binding (probably not), but I might recommend -1
Broken -- see the very end for unit test failures in AccessLogValve.

Environment:
Debian Linux Squeeze
OpenSSL 0.9.8o (Debian Packaged)
APR 1.4.2 (Debian Packaged)
Sun/Oracle Java 1.6.0_26 64-bit (Debian Packaged)
Apache ant 1.8.2

+ md5(apache-tomcat-7.0.33.zip): Matches
+ GPG verify (apache-tomcat-7.0.33.zip): Matches
+ md5(apache-tomcat-7.0.33.tar.gz): Matches
+ GPG verify (apache-tomcat-7.0.33.tar.gz): Matches
+ md5(apache-tomcat-7.0.33.exe): Matches
+ GPG verify (apache-tomcat-7.0.33.exe): Matches
+ Binary Zip and tarball:Same
+ md5(apache-tomcat-7.0.33-src.zip): Matches
+ GPG verify (apache-tomcat-7.0.33-src.zip): Matches
+ md5(apache-tomcat-7.0.33-src.tar.gz): Matches
+ GPG verify (apache-tomcat-7.0.33-src.tar.gz): Matches
+ Source Zip and tarball:Same
+ Deps download and compile cleanly (DBCP has some ant warnings)
+ tcnative builds cleanly (a few minor warnings using GCC 4.4.5 glibc
2.11.3)
+ Tomcat Source builds cleanly (some deprecation warnings)
/ Tribes unit tests fail (this is expected, right?)
- Other unit test failures:

TEST-org.apache.catalina.valves.TestAccessLogValve.APR.txt:Tests run: 1,
Failures: 1, Errors: 0, Time elapsed: 0.078 sec

Testcase: testBug54044 took 0.065 sec
        FAILED
arrays first differed at element [0]; expected:<...1/Dec/1969:19:00:00
[+00]00]> but was:<...1/Dec/1969:19:00:00 [-05]00]>
junit.framework.AssertionFailedError: arrays first differed at element
[0]; expected:<...1/Dec/1969:19:00:00 [+00]00]> but
was:<...1/Dec/1969:19:00:00 [-05]00]>
        at
org.apache.catalina.valves.TestAccessLogValve.testBug54044(TestAccessLogV=
alve.java:52)

---------

TEST-org.apache.catalina.valves.TestAccessLogValve.BIO.txt:Tests run: 1,
Failures: 1, Errors: 0, Time elapsed: 0.048 sec

Testcase: testBug54044 took 0.034 sec
        FAILED
arrays first differed at element [0]; expected:<...1/Dec/1969:19:00:00
[+00]00]> but was:<...1/Dec/1969:19:00:00 [-05]00]>
junit.framework.AssertionFailedError: arrays first differed at element
[0]; expected:<...1/Dec/1969:19:00:00 [+00]00]> but
was:<...1/Dec/1969:19:00:00 [-05]00]>
        at
org.apache.catalina.valves.TestAccessLogValve.testBug54044(TestAccessLogV=
alve.java:52)

---------
TEST-org.apache.catalina.valves.TestAccessLogValve.NIO.txt:Tests run: 1,
Failures: 1, Errors: 0, Time elapsed: 0.082 sec

Testcase: testBug54044 took 0.059 sec
        FAILED
arrays first differed at element [0]; expected:<...1/Dec/1969:19:00:00
[+00]00]> but was:<...1/Dec/1969:19:00:00 [-05]00]>
junit.framework.AssertionFailedError: arrays first differed at element
[0]; expected:<...1/Dec/1969:19:00:00 [+00]00]> but
was:<...1/Dec/1969:19:00:00 [-05]00]>
        at
org.apache.catalina.valves.TestAccessLogValve.testBug54044(TestAccessLogV=
alve.java:52)

Looks like the time zone is either not being calculated properly or not
being printed to the output stream properly.

-chris


--------------enigB9E6FA51AF255E1F09D74F4E
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iEYEARECAAYFAlCs2WQACgkQ9CaO5/Lv0PA/qgCfXk8i3InadNODbc1KSIuwe1Cn
m/QAn14ZZtVQZWkt0HvE8GW8tLBRAKxJ
=r3Ap
-----END PGP SIGNATURE-----

--------------enigB9E6FA51AF255E1F09D74F4E--