tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 54144] New: Processing of java.io.Reader in "Out" tagplugin
Date Wed, 14 Nov 2012 08:38:29 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=54144

          Priority: P2
            Bug ID: 54144
          Assignee: dev@tomcat.apache.org
           Summary: Processing of java.io.Reader in "Out" tagplugin
          Severity: minor
    Classification: Unclassified
                OS: Windows XP
          Reporter: knst.kolinko@gmail.com
          Hardware: PC
            Status: NEW
           Version: 7.0.32
         Component: Jasper
           Product: Tomcat 7

Reviewing r1401816 I see two issues in tagplugin
o.a.jasper.tagplugins.jstl.core.Out:

The code that the plugin generates calls value.toString(), default.toString()
and passes these String values to the static method Out.output(...). This new
method was added in r1401816.

I think the output() method should accept Objects instead of Strings, because
the following is wrong:

1. The evaluation of default.toString() is not needed at all if the default is
not used.

2. The JSTL spec (1.1, 1.2) says that there is special processing if value is
java.io.Reader. There is no such processing in the current code. (It seems that
this feature was added in JSTL 1.1).

[quote]
If the result of the evaluation is not a java.io.Reader object, then it is
coerced to
a String and is subsequently emitted into the current JspWriter object.

If the result of the evaluation is a java.io.Reader object, data is first read
from the
Reader object and then written into the current JspWriter object.
[/quote]

These two issues are not new - they existed before the recent changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message