tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53869] Performance tuning solution to resolve too many cascaded JspContextWrapper issue
Date Mon, 12 Nov 2012 08:56:28 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53869

--- Comment #7 from Konstantin Kolinko <knst.kolinko@gmail.com> ---
1. This change in JspContextWrapper constructor means that it will create EL
context regardless of whether it will be used or not:

+ this.elContext = rootJspCtxt.getELContext();

See PageContextImpl.getELContext(),
JspApplicationContextImpl.createELContext(..).

The EL Context creation operation involves using a PrivilegedAction and firing
an event through listeners. It is not cheap.

I think this change in behaviour is undesireable.


2. I do not expect much from your proposed optimization. Using a delegation is
a common pattern. Replacing 4 chained redirects with 1 redirect is not much of
a change.

3. If someone extends JspContextWrapper, its behaviour will be broken by this
change. (Is it a concern? Would anyone extend it? Isn't it Jasper internals?)

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message