tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1405980 - /tomcat/maven-plugin/trunk/init-git-svn.sh
Date Thu, 08 Nov 2012 22:29:43 GMT
2012/11/8 Olivier Lamy <olamy@apache.org>:
> apologize for delayed response (I'm on vacations :-) )
> So I have added a "how to contribute" page see
> http://tomcat.apache.org/maven-plugin-2.1-SNAPSHOT/how-to-contribute.html
>

OK. I have seen your commits.

Best regards,
Konstantin Kolinko

>
>
> 2012/11/6 Konstantin Kolinko <knst.kolinko@gmail.com>:
>> It would be better to add some comment at the top of the script,  describing
>> - what it is needed for  (whether it initializes "git", "svn" or "git-svn"),
>> - how often it has to be run ("once"? Though maybe more often if the
>> authors file is updated).
>>
>> Or maybe just mention that the file is described elsewhere, or follows
>> some procedure described elsewhere.
>>
>> It may be worth adding the AL header (though some say that trivial
>> files do not need it).
>>
>> Best regards,
>> Konstantin Kolinko
>>
>> 2012/11/6  <olamy@apache.org>:
>>> Author: olamy
>>> Date: Mon Nov  5 21:59:43 2012
>>> New Revision: 1405980
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1405980&view=rev
>>> Log:
>>> add init-git-svn.sh script to ease git svn setup
>>>
>>> Added:
>>>     tomcat/maven-plugin/trunk/init-git-svn.sh   (with props)
>>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message