tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Burch <br...@pingtoo.com>
Subject Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly
Date Thu, 29 Nov 2012 19:28:47 GMT
On 29/11/12 16:46, Rainer Jung wrote:
> On 29.11.2012 17:11, Brian Burch wrote:
>> On 29/11/12 14:37, bugzilla@apache.org wrote:
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=54190
>
>> When I looked quickly at your change, the "-" and "+" lines appeared to
>> be identical to me, so I was puzzled.
>>
>> Could you give me an example of what kind of warnings you were getting -
>> I noticed that you commented on having more than 40, so just the most
>> common one or two would be a help.
>
> If we are talking about r1415178, then it is Boolean -> boolean.

Wow! That was clumsy. Lots of recent work on wikis caused me to 
capitalise the data type without even realising. Then cut-n-paste 
propagated it. I'll see if I can tell netbeans to stop that in future 
cos I can't keep away from wikis!

I'm surprised that netbeans was happy to coerce the type back to boolean 
for the call to doTestBasic without even squeaking a little bit. I've 
learnt something valuable, so thanks for pointing it out.

> Regards,
>
> Rainer
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message