tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Burch <br...@pingtoo.com>
Subject Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly
Date Thu, 22 Nov 2012 17:32:30 GMT
On 22/11/12 16:46, bugzilla@apache.org wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=54190
>
> --- Comment #3 from Mark Thomas <markt@apache.org> ---
> Your logic makes sense to me so my preference would be some more comments.

I will think about our discussion and try to improve the comments and so 
hopefully avoid confusing future readers. I will submit a new 
self-contained patch and obsolete the current one.


Sorry to drift slightly (but not completely) off-topic. Could you give 
me your off-the-cuff opinion on this:

Context.setSessionTimeout(int timeoutInMinutes) obliges tests that need 
to explore session timeout behaviour to hang the test process for at 
least 60 seconds, although most of that delay would be unnecessary.

I don't actually know how often the Manager (is that the right 
component?) scans to expire Sessions, but it must do it more frequently 
than once a minute.

I realise the method signature is part of a public api, but do you have 
a view on adding an alternative method to 
org.apache.catalina.core.StandardContext so that unit tests could set a 
session timeout in seconds?

Thanks,

Brian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message