tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1408150 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/AsyncContextImpl.java webapps/docs/changelog.xml
Date Tue, 13 Nov 2012 13:47:50 GMT
On 13/11/2012 01:08, Konstantin Kolinko wrote:
> 2012/11/12  <markt@apache.org>:
>> Author: markt
>> Date: Sun Nov 11 23:32:43 2012
>> New Revision: 1408150
>>
>> URL: http://svn.apache.org/viewvc?rev=1408150&view=rev
>> Log:
>> both timeout and complete, as with all container callbacks must be invoked with the
right context
>> Backport of fhanik's r1356898
> 
> 
> 1. The change only takes care of timeout().
> What about complete (fireOnComplete()) that is mentioned in the commit
> message and in the changelog?

This was a straight backport so my subsequent change would apply
cleanly. I agree it looks like firOnComplete() needs this too.

> 
> 2. I wonder what about running with SecurityManager. (Well, timeout()
> is probably called by Tomcat code, so there might be no concern, or
> maybe you will notice it while running TCK).

It looks to me like neither can be called directly from user code.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message