tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Resources - merging back the changes
Date Thu, 01 Nov 2012 18:55:43 GMT
On 01/11/2012 18:25, Mark Thomas wrote:
> On 01/11/2012 05:21, Costin Manolache wrote:
>> On Wed, Oct 31, 2012 at 4:41 PM, Costin Manolache <costin@gmail.com> wrote:
>>
>>> Hi Mark,
>>>
>>> I synced from HEAD - and noticed that DefaultServlet.PUT now fails with
>>> '403' if the resource already exists.
>>> I'm pretty sure this used to work, and at least for webdav it's supposed
>>> to replace the content.
>>> Is this a bug - or intended (the problem seems to be preResourceExists()
>>> check in StandardRoot.write()) ?
>>>
>>
>> Sorry - my mistake reading the code, with a debugger I see
>> preResourceExist() is fine, but DirResourceSet.write() has a check - and
>> from the javadoc the intent seems to be to not overwrite.
>>
>> IMHO it would be better to change the javadoc and implementation to allow
>> overwrites. Alternative is to
>> do a delete before in webdav/default servlet - but I don't see what use
>> case is optimized by not allowing overwrites.
> 
> It looks like I didn't include an equivalent of rebind() in the new
> resources implementation. That was an oversight rather than an
> intentional decision. I'll fix that next.

Fixed in r1404724.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message