Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <506EEA07.7050205@christopherschultz.net>
Date: Fri, 05 Oct 2012 10:09:11 -0400
From: Christopher Schultz <chris@christopherschultz.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8;
 rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: svn commit: r1394104 - in /tomcat/tc6.0.x/trunk: ./
 java/org/apache/catalina/connector/
 webapps/docs/ webapps/docs/config/
References: <20121004145600.405BB23889D7@eris.apache.org>
 <CABzHfV=gtY+tn1V9D2hwj8RGVVV6WBGmf-4G+CZsCr1E2ZE1tg@mail.gmail.com>
In-Reply-To: 
 <CABzHfV=gtY+tn1V9D2hwj8RGVVV6WBGmf-4G+CZsCr1E2ZE1tg@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig87C76D7E75E1ABDE24642DC0"

--------------enig87C76D7E75E1ABDE24642DC0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Konstantin,

On 10/5/12 8:45 AM, Konstantin Kolinko wrote:
> 2012/10/4  <markt@apache.org>:
>> Author: markt
>> Date: Thu Oct  4 14:55:59 2012
>> New Revision: 1394104
>>
>> URL: http://svn.apache.org/viewvc?rev=3D1394104&view=3Drev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=3D48692
>> Provide option to parse application/x-www-form-urlencoded PUT requests=

>>
>> Modified:
>>     tomcat/tc6.0.x/trunk/STATUS.txt
>>     tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.=
java
>>     tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/LocalStrin=
gs.properties
>>     tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.ja=
va
>>     tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
>>     tomcat/tc6.0.x/trunk/webapps/docs/config/ajp.xml
>>     tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml
>>
>=20
>> (...)
>> Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Requ=
est.java
>> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache=
/catalina/connector/Request.java?rev=3D1394104&r1=3D1394103&r2=3D1394104&=
view=3Ddiff
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.ja=
va (original)
>> +++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.ja=
va Thu Oct  4 14:55:59 2012
>> @@ -2596,7 +2596,7 @@ public class Request
>>          if (usingInputStream || usingReader)
>>              return;
>>
>> -        if (!getMethod().equalsIgnoreCase("POST"))
>> +        if( !getConnector().isParseBodyMethod(getMethod()) )
>>              return;
>=20
>=20
> It seems a bug crawled in.
> The old behaviour: case-insensitive. equalsIgnoreCase("POST")
> The new behaviour: case-sensitive  (parseBodyMethodsSet.contains(method=
))
>=20
> That is unless the method name is converted to uppercase somewhere.
> I have not yet checked what HTTP spec says on method names.

RFCs 2616, 2068, and 1945 all agree that method name is case-sensitive:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.1

-chris


--------------enig87C76D7E75E1ABDE24642DC0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlBu6goACgkQ9CaO5/Lv0PC7FACfUi6+8Ho29kqmYtuzeNMcs5ty
0KkAn2j1WCEg7S15eKyW7zxtoveBvngM
=seZW
-----END PGP SIGNATURE-----

--------------enig87C76D7E75E1ABDE24642DC0--