Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 14861DDD4 for ; Mon, 1 Oct 2012 21:55:26 +0000 (UTC) Received: (qmail 90396 invoked by uid 500); 1 Oct 2012 21:55:25 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 90336 invoked by uid 500); 1 Oct 2012 21:55:25 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 90326 invoked by uid 99); 1 Oct 2012 21:55:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Oct 2012 21:55:25 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Oct 2012 21:55:23 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 34EDF23888CD for ; Mon, 1 Oct 2012 21:54:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1392652 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java Date: Mon, 01 Oct 2012 21:54:39 -0000 To: dev@tomcat.apache.org From: markt@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121001215439.34EDF23888CD@eris.apache.org> Author: markt Date: Mon Oct 1 21:54:38 2012 New Revision: 1392652 URL: http://svn.apache.org/viewvc?rev=1392652&view=rev Log: Fix some warnings: - Findbugs - not serializable - Eclipse - unchecked conversion Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java?rev=1392652&r1=1392651&r2=1392652&view=diff ============================================================================== --- tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java (original) +++ tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java Mon Oct 1 21:54:38 2012 @@ -901,9 +901,10 @@ public class PoolProperties implements P } - public static class InterceptorDefinition { + public static class InterceptorDefinition implements Serializable { + private static final long serialVersionUID = 1L; protected String className; - protected Map properties = new HashMap(); + protected Map properties = new HashMap<>(); protected volatile Class clazz = null; public InterceptorDefinition(String className) { this.className = className; @@ -930,6 +931,7 @@ public class PoolProperties implements P return properties; } + @SuppressWarnings("unchecked") public Class getInterceptorClass() throws ClassNotFoundException { if (clazz==null) { if (getClassName().indexOf(".")<0) { @@ -948,7 +950,8 @@ public class PoolProperties implements P } } - public static class InterceptorProperty { + public static class InterceptorProperty implements Serializable { + private static final long serialVersionUID = 1L; String name; String value; public InterceptorProperty(String name, String value) { --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org