tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1394104 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/
Date Fri, 05 Oct 2012 12:45:12 GMT
2012/10/4  <markt@apache.org>:
> Author: markt
> Date: Thu Oct  4 14:55:59 2012
> New Revision: 1394104
>
> URL: http://svn.apache.org/viewvc?rev=1394104&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48692
> Provide option to parse application/x-www-form-urlencoded PUT requests
>
> Modified:
>     tomcat/tc6.0.x/trunk/STATUS.txt
>     tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java
>     tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/LocalStrings.properties
>     tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java
>     tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
>     tomcat/tc6.0.x/trunk/webapps/docs/config/ajp.xml
>     tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml
>

>(...)
> Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java
> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java?rev=1394104&r1=1394103&r2=1394104&view=diff
> ==============================================================================
> --- tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java (original)
> +++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java Thu Oct  4 14:55:59
2012
> @@ -2596,7 +2596,7 @@ public class Request
>          if (usingInputStream || usingReader)
>              return;
>
> -        if (!getMethod().equalsIgnoreCase("POST"))
> +        if( !getConnector().isParseBodyMethod(getMethod()) )
>              return;


It seems a bug crawled in.
The old behaviour: case-insensitive. equalsIgnoreCase("POST")
The new behaviour: case-sensitive  (parseBodyMethodsSet.contains(method))

That is unless the method name is converted to uppercase somewhere.
I have not yet checked what HTTP spec says on method names.

>
>          String contentType = getContentType();
>

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message