tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: [Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation
Date Tue, 09 Oct 2012 23:38:53 GMT
All,

On 10/9/12 6:07 PM, bugzilla@apache.org wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=53986
> 
> --- Comment #4 from Christopher Schultz <chris@christopherschultz.net> ---
> (In reply to comment #3)
>> Possible cause: r1381417
> 
> Reverting that patch resolves the issue in 7.0.x/trunk, so the regression
> appears to be in there. I'm not sure where, though.

Given that r1381417 breaks comment-parsing, should we just revert the
whole thing? I have a test case set up that currently fails in
7.0.x/trunk but runs correctly with r1381417 reverted.

My plan is to commit the revert of r1381417 plus the test case, then
mark the original bug as reopened and ask the original author of the
patch if they might look into why comments aren't working properly. The
addition of the aforementioned test case should help.

-chris


Mime
View raw message