Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: neutral (athena.apache.org: local policy)
User-Agent: K-9 Mail for Android
In-Reply-To: 
 <CABzHfVnnM7KK63nanXUG6xXfkTCA3pqrkVWhdxFD2f0PtM-gUQ@mail.gmail.com>
References: <20120923210923.32EB123888FE@eris.apache.org>
 <CABzHfVnnM7KK63nanXUG6xXfkTCA3pqrkVWhdxFD2f0PtM-gUQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: svn commit: r1389145 - in /tomcat/trunk/java/org/apache:
 catalina/connector/CoyoteAdapter.java
 tomcat/util/collections/ConcurrentWeakHashMap.java
From: Mark Thomas <markt@apache.org>
Date: Mon, 24 Sep 2012 12:18:58 +0100
To: Tomcat Developers List <dev@tomcat.apache.org>
Message-ID: <0dccee29-ca5c-4e79-8660-6c5c8e2eaf1c@email.android.com>

Konstantin Kolinko <knst.kolinko@gmail.com> wrote:

>2012/9/24  <markt@apache.org>:
>> Author: markt
>> Date: Sun Sep 23 21:09:22 2012
>> New Revision: 1389145
>>
>> URL: http://svn.apache.org/viewvc?rev=1389145&view=rev
>> Log:
>> Some more low(ish) hanging fruit from the allocation hit list. This
>accounts for ~8% due to the way Thread stores names.


>-1 for ReadWriteLock.
>The problem with WeakHashMap is that its get() operation can modify it
>(as it processes referencequeue).  Thus you cannot use ReadWriteLock,
>but must use plain synchronization here.

Yep. I'll remove that class. ThreadLocal is a better solution for this problem anyway. Not sure why I didn't think of that the first time. I'll fix this later today.

Cheers,

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org