tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53897] New: Customized EL resolver to improve the performance of EL resolving
Date Wed, 19 Sep 2012 06:19:56 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53897

          Priority: P2
            Bug ID: 53897
          Assignee: dev@tomcat.apache.org
           Summary: Customized EL resolver to improve the performance of
                    EL resolving
          Severity: enhancement
    Classification: Unclassified
          Reporter: xshao@ebay.com
          Hardware: PC
            Status: NEW
           Version: trunk
         Component: Jasper
           Product: Tomcat 7

Created attachment 29393
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29393&action=edit
Comparison test case

CustomizedELResolver is to simplify and make it efficient for EL resolving.

1. The code in CustomizedELResolver is copied from CompositeELResolver.
 2. Performance tuning is focus on getValue, because it was the big hotspot of
one page hit if the page includes many ELs.
 3. getValue switchs by "base"
 If the base is null, it follows next steps to check value,
 A. ImplicitObjectELResolverImpl(Optimized from ImplicitObjectELResolverImpl)
 B. Extended ELResolvers
 C. ScopedAttributeELResolverImpl(Extends ScopedAttributeELResolverImpl,
supports get value by property name)

 Else the base is not null, it checks extended ELResolvers first, then tries to
get value from Map, ResourceBundle, List, Array or Bean one by one until the
property was resolved.

Q: Why split extSize == 1 to another block ?
 A: To avoid an additional "context.setPropertyResolved(false);"

Q: Why check value from Map, ResourceBundle, List and Array directly in
CustomizedELResolver ?
 A To avoid extra valiation in ELResolver.getValue.

Description for attached files.
 1. CustomizedELResolver: The implementation for this fix.
 2 JspApplicationContextImpl.diff : Patch for how to apply this new resolver.
 3. ScopedAttributeELResolverImpl.java: Extension of
ScopedAttributeELResolverImpl.
 4. TestPageContext.java: Test case to compare the new ELResolver with
CompositeELResolver
 5. ImplicitObjectELResolverImpl.java: related with another bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53895

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message