tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53828] New: StreamInbound.closeOutboundConnection(WsFrame) closes with an opcode instead of status
Date Tue, 04 Sep 2012 16:55:42 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53828

          Priority: P2
            Bug ID: 53828
          Assignee: dev@tomcat.apache.org
           Summary: StreamInbound.closeOutboundConnection(WsFrame) closes
                    with an opcode instead of status
          Severity: minor
    Classification: Unclassified
                OS: All
          Reporter: michael.newcomb@gdc4s.com
          Hardware: PC
            Status: NEW
           Version: trunk
         Component: Catalina
           Product: Tomcat 7

201    private void closeOutboundConnection(WsFrame frame) throws IOException {
202      try {
203        getWsOutbound().close(frame);
204      } finally {
205        doOnClose(Constants.OPCODE_CLOSE);
206      }
207    }

Line 205 uses the close opcode instead of a valid status (Constants.STATUS_*).

Not sure of the exact context of this called but it seems to only be called
when the last frame from the client was a close frame, thus a
Constants.STATUS_NORMAL may be in order.

If not, the frame's opcode could be inspected and mapped to an appropriate
status (normal, shutdown, etc...).

Thanks,
Michael

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message