tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Resources - The need for refactoring
Date Fri, 14 Sep 2012 18:12:13 GMT
On 09/09/2012 19:34, Mark Thomas wrote:
> This is issue a) in Konstantin's comments in TOMCAT-NEXT.txt
> 
> My expectation is that the need for refactoring in some form or another
> is clear. Currently Tomcat has the following features:
> - aliases
> - resource JARs
> - VirtualDirContext / VirtualLoader
> 
> and in Servlet 3.1 there will be overlays. [1]
> 
> Each of these features (except overlays which isn't implemented yet)
> does almost the same thing each in slightly different ways. The code is
> already quite messy and adding overlay support is going to be really
> difficult without some refactoring. The various bugs we have seen in the
> Virtual[Context|Loader] implementation hasn't been great and I am
> concerned that an overlay implementation built on the existing code will
> be fragile.
> 
> A refactored, coherent resources implementation will make implementing
> overlays a lot simpler. The new resources implementation I just
> committed already supports overlays - it just needs plumbing in to
> whatever API the Servlet EG defines.
> 
> I view this issue not as what the refactoring should look like but that
> there is a need for a refactoring of some form before any further
> features are added for resource handling.

I haven't seen any arguments against this point. If none are forthcoming
in the next few days, I am going to assume that there is no argument
that refactoring of the resource handling is required for Tomcat 8.0.x
(although there may well be different views on what that refactoring
should look like).

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message