tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1380381 - /tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java
Date Mon, 03 Sep 2012 21:55:14 GMT
Author: markt
Date: Mon Sep  3 21:55:14 2012
New Revision: 1380381

URL: http://svn.apache.org/viewvc?rev=1380381&view=rev
Log:
Clean-up
- fix false positive NPE warnings by removing redundant code and suppressing remaining warning

Modified:
    tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java

Modified: tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java?rev=1380381&r1=1380380&r2=1380381&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java Mon Sep  3 21:55:14 2012
@@ -337,9 +337,6 @@ class PageInfo {
      */
     public void popPrefixMapping(String prefix) {
         LinkedList<String> stack = xmlPrefixMapper.get(prefix);
-        if (stack == null || stack.size() == 0) {
-            // XXX throw new Exception("XXX");
-        }
         stack.removeFirst();
     }
 
@@ -465,6 +462,7 @@ class PageInfo {
                 }
             }
             try {
+                @SuppressWarnings("null") // value can't be null here
                 Integer k = new Integer(value.substring(0, value.length()-2));
                 buffer = k.intValue() * 1024;
             } catch (NumberFormatException e) {



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message