tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1389145 - in /tomcat/trunk/java/org/apache: catalina/connector/CoyoteAdapter.java tomcat/util/collections/ConcurrentWeakHashMap.java
Date Mon, 24 Sep 2012 11:18:58 GMT
Konstantin Kolinko <knst.kolinko@gmail.com> wrote:

>2012/9/24  <markt@apache.org>:
>> Author: markt
>> Date: Sun Sep 23 21:09:22 2012
>> New Revision: 1389145
>>
>> URL: http://svn.apache.org/viewvc?rev=1389145&view=rev
>> Log:
>> Some more low(ish) hanging fruit from the allocation hit list. This
>accounts for ~8% due to the way Thread stores names.


>-1 for ReadWriteLock.
>The problem with WeakHashMap is that its get() operation can modify it
>(as it processes referencequeue).  Thus you cannot use ReadWriteLock,
>but must use plain synchronization here.

Yep. I'll remove that class. ThreadLocal is a better solution for this problem anyway. Not
sure why I didn't think of that the first time. I'll fix this later today.

Cheers,

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message