Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Date: Sat, 4 Aug 2012 20:13:02 +0000 (UTC)
From: =?utf-8?Q?Olivier_Lamy_=28*=24=5E=C2=A8=25=60=C2=A3=29_=28JIRA=29?=
 <jira@apache.org>
To: dev@tomcat.apache.org
Message-ID: <782798152.13695.1344111182768.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <1878803534.34295.1331131738620.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MTOMCAT-124) tomcat-maven-archetype unused
 generation parameters
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MTOMCAT-124?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D134=
28671#comment-13428671 ]=20

Olivier Lamy (*$^=C2=A8%`=C2=A3) commented on MTOMCAT-124:
------------------------------------------------

Hi,
I tried to apply your patch but It doesn't build.
How did you generate your patch ? Can you post a new one ?
Thanks
               =20
> tomcat-maven-archetype unused generation parameters
> ---------------------------------------------------
>
>                 Key: MTOMCAT-124
>                 URL: https://issues.apache.org/jira/browse/MTOMCAT-124
>             Project: Apache Tomcat Maven Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0-beta-1
>            Reporter: patrick garcia
>            Assignee: Olivier Lamy (*$^=C2=A8%`=C2=A3)
>            Priority: Trivial
>              Labels: archetype, maven, tomcat
>             Fix For: 2.1
>
>         Attachments: MTOMCAT-124-tomcat-maven-archetype.patch
>
>
> I found several problems on the superb and very useful "tomcat-maven-arch=
etype"
> The improvement I propos are the followings:
> 1/
> "groupId" and "version" can have default values but should be prompt for =
user value the same way as for "version" of "org.apache.maven.archetypes:ma=
ven-archetype-quickstart:1.1"
> "org.apache.maven.archetypes:maven-archetype-quickstart:1.1" proposes a d=
efault "version" and prompt the user for modification at the same time. Pre=
ssing enter validate the default value.
> 2/
> Following variables are not in used:
> =09artifactId-api
> =09artifactId-api-impl
> =09artifactId-webapp
> =09artifactId-webapp-exec
> =09artifactId-webapp-it
> This variables should impact the "mvn archetype:generate" behaviour
> 3/
> I propos to change the default values of :
> =09artifactId-api =3D ${artifactId}-api
> =09artifactId-api-impl =3D ${artifactId}-api-impl
> =09artifactId-webapp =3D ${artifactId}-webapp
> =09artifactId-webapp-exec =3D ${artifactId}-webapp-exec
> =09artifactId-webapp-it =3D ${artifactId}-webapp-it
> 4/
> rootArtifactId cat be renamed as artifactId with no default value
> I will propos patches for this later. I, first, have to understand "arche=
type" framework.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org