tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1358055 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/spdy/ java/org/apache/tomcat/uti
Date Fri, 03 Aug 2012 18:53:24 GMT
On 6 July 2012 07:53,  <fhanik@apache.org> wrote:
> Author: fhanik
> Date: Fri Jul  6 06:53:52 2012
> New Revision: 1358055
>
> URL: http://svn.apache.org/viewvc?rev=1358055&view=rev
> Log:
> implement rev 1 of async/non blocking writes
>
>

> Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java?rev=1358055&r1=1358054&r2=1358055&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java (original)
> +++ tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java Fri Jul 
6 06:53:52 2012

> @@ -146,8 +226,12 @@ public class InternalNioOutputBuffer ext
>       * @throws IOException
>       * TODO Fix non blocking write properly
>       */
> +    int total = 0;

The above is in the wrong place; it should either be before the
Javadoc or after the private method body, not between them.

>      private synchronized int writeToSocket(ByteBuffer bytebuffer, boolean block, boolean
flip) throws IOException {
> -        if ( flip ) bytebuffer.flip();
> +        if ( flip ) {
> +            bytebuffer.flip();
> +            flipped = true;
> +        }
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message