tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1377544 - in /tomcat/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/config/systemprops.xml
Date Mon, 27 Aug 2012 06:39:28 GMT


fhanik@apache.org wrote:

>Author: fhanik
>Date: Sun Aug 26 23:48:01 2012
>New Revision: 1377544
>
>URL: http://svn.apache.org/viewvc?rev=1377544&view=rev
>Log:
>don't hard code values, no need to
>https://issues.apache.org/bugzilla/show_bug.cgi?id=53267

-1 for two reasons:

1. Users should have no need to set this value. It is part of the internal Sun API. Tomcat
sets it solely to avoid a memory leak and does so in a manner that will not affect the JVM
setting any alternative value(s). I do not see any valid use case for a user needing to set
this.

2. If such a setting were to be provided, it should be as a property of the listener, not
as a system property. There is no requirement for a system property here.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message