tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1377511 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/JspConfig.java java/org/apache/jasper/compiler/TldLocationsCache.java java/org/apache/jasper/compiler/WebXml.java webapps/docs/changelog.xml
Date Sun, 26 Aug 2012 21:23:05 GMT
On 26/08/2012 22:16, Konstantin Kolinko wrote:
> 2012/8/27  <markt@apache.org>:
>> Author: markt
>> Date: Sun Aug 26 20:29:27 2012
>> New Revision: 1377511
>>
>> URL: http://svn.apache.org/viewvc?rev=1377511&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53737
>> Access JSP configuration information via the ServletContext rather than re-parsing
web.xml
>>
>> Modified:
>>     tomcat/tc7.0.x/trunk/   (props changed)
>>     tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/JspConfig.java
>>     tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/TldLocationsCache.java
>>     tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/WebXml.java
>>     tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
>>
> 
> I have not tested yet, but there are two things that I wonder
> regarding this change
> 
> 1) Is JspC still working?
> 
>  It uses JspCServletContext which implementation of
> #getJspConfigDescriptor() always returns null.

I haven't tested that. On the face of it, this change may need to be
reverted / modified.

> 2) Can we stop publishing merged web.xml as context attribute (make
> this publishing off by default)?

Potentially, yes.

Mark

> 
>   org.apache.tomcat.util.scan.Constants.MERGED_WEB_XML
> 
> Best regards,
> Konstantin Kolinko
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message