tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject svn commit: r1372415 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Mon, 13 Aug 2012 13:06:43 GMT
Author: kkolinko
Date: Mon Aug 13 13:06:43 2012
New Revision: 1372415

Change votes where my concerns were addressed.
Add formatting fix to schultz's proposal.


Modified: tomcat/tc6.0.x/trunk/STATUS.txt
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Aug 13 13:06:43 2012
@@ -145,31 +145,14 @@ PATCHES PROPOSED TO BACKPORT: (addresses kkolinko's -1)
   +1: markt, schultz
-  -1: kkolinko:
-     Regarding FormAuthenticator.restoreRequest(..):
-     My -1 is because decodedURI is saved into SavedRequest in #saveRequest(..)
-     but is restored into requestURI field in #restoreRequest(..).
-     The following are my concerns:
-     1. The web application protected by FORM auth might have expected path
-     parameters, and now those are lost from requestURI.
-     2. The decodedURI value is url-decoded in CoyoteAdapter.postParseRequest(..),
-     while requestURI is not. Using one for the other changes behaviour.
-     3. An issue that exists in the old code as well: I wonder why
-     decodedURI value is not restored by restoreRequest(). It looks like a
-     bug. I think an observable consequence is that o.a.c.connector.Request#toAbsolute()
-     will return different values because of different values of decodedURI.
-     The BZ 53584 bug is essentially in matchRequest(..) and I agree that it should
-     be changed to compare decodedURI values.
-     Can SavedRequest store both requestURI and decodedURI values and
-     restore both of them?
+  +1: kkolinko (OK, my concerns were addressed)
+  -1:
 * Fix
   Add support for SSLHonorCipherOrder (rolls-back inadvertent
addition of TOMCAT-NEXT.txt)
+ (tab -> spaces)
   +1: schultz
@@ -178,12 +161,14 @@ PATCHES PROPOSED TO BACKPORT:
   Patch from 7.0.x should apply relatively cleanly, as it is very small:
   +1: schultz
-  -1: kkolinko: r1041892 is not enough. It has bad formatting, a HashMap
+   0: kkolinko: r1041892 is not enough. It has bad formatting, a HashMap
   protected field (should be 'Map'), etc. See the current code of Tomcat 7.
       schultz: current trunk and TC7 code has HashSet<String>. Am I misunderstanding?
                I will also add
                to fix the formatting issues.
+      kkolinko: If we missed it, then it has to be fixed in trunk. I think
+      a patch for 6.0 is needed to properly review the change here.
 * Further fixes for
   - Use standard text for standard HTTP error codes 

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message