tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "patrick garcia (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MTOMCAT-124) tomcat-maven-archetype unused generation parameters
Date Sun, 05 Aug 2012 00:18:02 GMT

     [ https://issues.apache.org/jira/browse/MTOMCAT-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

patrick garcia updated MTOMCAT-124:
-----------------------------------

    Attachment: MTOMCAT-124-tomcat-maven-archetype2.patch

Ok,

Here is a refreshed patch "MTOMCAT-124-tomcat-maven-archetype2.patch" done in repository version
1362736, while checked out "https://svn.apache.org/repos/asf/tomcat/maven-plugin/trunk/tomcat-maven-archetype"

This patch replaces the old one.

I have tested it with the following commands under Windows:

mkdir "%temp%\xxx"
cd /d "%temp%\xxx"
svn co https://svn.apache.org/repos/asf/tomcat/maven-plugin/trunk/tomcat-maven-archetype
cd "%temp%\xxx\tomcat-maven-archetype"
svn patch C:\MTOMCAT-124-tomcat-maven-archetype2.patch

set JAVA_HOME=c:\Program Files\Java\jdk1.6.0_25
mvn clean install
mvn clean

                
> tomcat-maven-archetype unused generation parameters
> ---------------------------------------------------
>
>                 Key: MTOMCAT-124
>                 URL: https://issues.apache.org/jira/browse/MTOMCAT-124
>             Project: Apache Tomcat Maven Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0-beta-1
>            Reporter: patrick garcia
>            Assignee: Olivier Lamy (*$^¨%`£)
>            Priority: Trivial
>              Labels: archetype, maven, tomcat
>             Fix For: 2.1
>
>         Attachments: MTOMCAT-124-tomcat-maven-archetype.patch, MTOMCAT-124-tomcat-maven-archetype2.patch
>
>
> I found several problems on the superb and very useful "tomcat-maven-archetype"
> The improvement I propos are the followings:
> 1/
> "groupId" and "version" can have default values but should be prompt for user value the
same way as for "version" of "org.apache.maven.archetypes:maven-archetype-quickstart:1.1"
> "org.apache.maven.archetypes:maven-archetype-quickstart:1.1" proposes a default "version"
and prompt the user for modification at the same time. Pressing enter validate the default
value.
> 2/
> Following variables are not in used:
> 	artifactId-api
> 	artifactId-api-impl
> 	artifactId-webapp
> 	artifactId-webapp-exec
> 	artifactId-webapp-it
> This variables should impact the "mvn archetype:generate" behaviour
> 3/
> I propos to change the default values of :
> 	artifactId-api = ${artifactId}-api
> 	artifactId-api-impl = ${artifactId}-api-impl
> 	artifactId-webapp = ${artifactId}-webapp
> 	artifactId-webapp-exec = ${artifactId}-webapp-exec
> 	artifactId-webapp-it = ${artifactId}-webapp-it
> 4/
> rootArtifactId cat be renamed as artifactId with no default value
> I will propos patches for this later. I, first, have to understand "archetype" framework.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message