tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [Bug 53529] Call interrupt() after InterruptedException instead interrupted()
Date Fri, 27 Jul 2012 23:14:02 GMT

Mark Thomas <> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Mark Thomas <> ---
Not one of these was a valid bug. There was scope to remove some unnecessary
code and improve some log messages a little which is the only reason this
wasn't closed as invalid. I have said this before and I'll say it again. Before
reporting something as a bug because it looks like a typical bug pattern,
please do the Tomcat committers the courtesy of actually analyzing the code to
see if there really is a problem. 

The only issue that came close to the original bug report was:
line 228
For this issue there was a marginal benefit to re-setting the interrupt flag
and clearing it later as it allowed a specific error message to be generated in
the unlikely event that there was an interrupt. This has been fixed in trunk
(for 8.0.x) and I see no need to back-port the change.

The following were all unnecessary attempts to clear the interrupt flag and
continue. The attempt is unnecessary since throwing InterruptedException clears
the interrupt flag. I have fixed these in trunk but I see no need to back-port
the changes.
line 692
line 173
line 124
line 146
line 640
line 112
line 177
line 187

The following was an unnecessary attempt to catch InterruptedException when it
is not thrown. This have been removed from trunk but I see no need to back-port
the change.
line 542

You are receiving this mail because:
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message