tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r1361432 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
Date Mon, 16 Jul 2012 12:21:45 GMT
On 16.07.2012 13:26, Mark Thomas wrote:
> Rainer Jung <rainer.jung@kippdata.de> wrote:
>
>> On 14.07.2012 00:42, markt@apache.org wrote:
>>> Author: markt
>>> Date: Fri Jul 13 22:42:42 2012
>>> New Revision: 1361432
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1361432&view=rev
>>> Log:
>>> Remove unused code
>>>
>>> Modified:
>>>
>> tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
>>>
>>> Modified:
>> tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
>>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java?rev=1361432&r1=1361431&r2=1361432&view=diff
>>>
>> ==============================================================================
>>> ---
>> tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
>> (original)
>>> +++
>> tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Fri
>> Jul 13 22:42:42 2012
>>> @@ -236,33 +236,8 @@ public class WebappClassLoader
>>>        }
>>>
>>>
>>> -    /**
>>> -     * Construct a new ClassLoader with no defined repositories and
>> the given
>>> -     * parent ClassLoader.
>>> -     *
>>> -     * @param parent Our parent class loader
>>> -     *
>>> -     * @deprecated  Unused - will be removed in 8.0.x
>>> -     */
>>> -    @Deprecated
>>> -    public WebappClassLoader(ClassLoader parent) {
>>> -
>>> -        super(new URL[0], parent);
>>> -
>>> -        this.parent = getParent();
>>> -
>>> -        system = getSystemClassLoader();
>>> -        securityManager = System.getSecurityManager();
>>> -
>>> -        if (securityManager != null) {
>>> -            refreshPolicy();
>>> -        }
>>> -    }
>>
>> I get lots of test failures. This one seems to be used via reflection
>> in
>> WebappLoader:
>
> Ok. Could you revert that commit for me please along with the deprecation. I'd do it
myself but I won't have easy access to do that for a few days.

NP

> Also, it would be worth adding a comment to the method's Javadoc.

Done and done.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message