tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53374] DataSourceFactory does not support commitOnReturn property
Date Wed, 06 Jun 2012 21:37:52 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53374

Konstantin Kolinko <knst.kolinko@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28897|0                           |1
           is patch|                            |
  Attachment #28897|application/octet-stream    |text/plain
          mime type|                            |

--- Comment #2 from Konstantin Kolinko <knst.kolinko@gmail.com> ---
Comment on attachment 28897
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28897
Patch for the fix.

You patch includes a lot of formatting changes. This is a no-go. Please include
only changes relevant to your fix.

Those seem to be

-        PROP_ALTERNATE_USERNAME_ALLOWED
+            PROP_ALTERNATE_USERNAME_ALLOWED,
+            PROP_COMMIT_ON_RETURN

and

+        value = properties.getProperty(PROP_COMMIT_ON_RETURN);
+        if (value != null) {
+            poolProperties.setCommitOnReturn(Boolean.parseBoolean(value));
+        }
+

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message