tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53333] NPE is thrown for env-entry without env-entry-type but with injection-target specified
Date Fri, 01 Jun 2012 20:05:03 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53333

--- Comment #2 from Mark Thomas <markt@apache.org> ---
Thanks for pointing this out. It is definitely a bug.

As I started to look at this I found some clean-up that could be done. It
changes the failure point although I think the patch is currently trying to
identify the type at the correct point. However, I'm not sure that
NamingResources is the best home for the actual functionality. I think some
refactoring may be in order. I'm looking at the now.

I also think that the specification wording is ambiguous. There is
<quote>
type may be ommitted or MUST match the type of the injection target
</quote>
and
<quote>
type MUST be assignment compatible with the type of the injection target
</quote>

Clearly the wording is different but I am not convinced that the meaning is. It
depends what is meant by "match". I am leaning towards implementing the more
flexible "assignment compatible" in all cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message