tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olivier Lamy <ol...@apache.org>
Subject Re: svn commit: r1351375 - /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
Date Tue, 19 Jun 2012 09:14:57 GMT
good catch !

Fixed.

Thanks
--
Olivier

2012/6/19 Konstantin Kolinko <knst.kolinko@gmail.com>:
> 2012/6/18  <olamy@apache.org>:
>> Author: olamy
>> Date: Mon Jun 18 14:57:32 2012
>> New Revision: 1351375
>>
>> URL: http://svn.apache.org/viewvc?rev=1351375&view=rev
>> Log:
>> [MTOMCAT-162] SaxException when deploying multiple WARs
>> Submitted by Neale Upstone.
>>
>> Modified:
>>    tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
>
>> --- tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
(original)
>> +++ tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java
Mon Jun 18 14:57:32 2012
>> @@ -86,7 +86,7 @@ public class RunMojo
>>      * @see http://tomcat.apache.org/tomcat-6.0-doc/api/org/apache/catalina/loader/WebappLoader.html#setDelegate(boolean)
>>      * @since 1.0
>>      */
>> -    private boolean delegate = true;
>> +    private final boolean delegate = true;
>
> The above change is odd.
> It is annotated as "@parameter" but you are marking it as final...
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message