tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1352454 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Sat, 23 Jun 2012 17:02:22 GMT
2012/6/21  <markt@apache.org>:
> Author: markt
> Date: Thu Jun 21 08:42:27 2012
> New Revision: 1352454
>
> URL: http://svn.apache.org/viewvc?rev=1352454&view=rev
> Log:
> Vote
>
> Modified:
>    tomcat/tc6.0.x/trunk/STATUS.txt
>

> @@ -156,14 +156,17 @@ PATCHES PROPOSED TO BACKPORT:
> * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52850
>  Extend memory leak prevention and detection code to
>   work with IBM as well as Oracle JVMs. Based on patch provided by Rohit Kelapure.
>   https://issues.apache.org/bugzilla/attachment.cgi?id=28893
>   +1: kkolinko, schultz
> -  -1:
> +  -1: markt - The patch removes some error handling, probably because the patch
> +              it was ported from was applied post r1201555 which was not ported
> +              to TC6. As a minimum, the WebappClassLoader needs the changes from
> +              r1201555 before this patch is applied

Mark,
can you explain what change in error handling do you see in proposed patch?

The only change that I see are catches for "NoSuchFieldException", and
that change is required to handle different JRE versions where certain
fields are missing.

NoSuchFieldException is a checked exception, so where its handling was
removed it is because it is not thrown there.

Handling of other exceptions has not changed.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message