tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neale Upstone (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MTOMCAT-160) "Skipping non-war project" should not happen if using <addContextWarDependencies>
Date Mon, 18 Jun 2012 15:26:42 GMT

    [ https://issues.apache.org/jira/browse/MTOMCAT-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13395958#comment-13395958
] 

Neale Upstone commented on MTOMCAT-160:
---------------------------------------

Shouldn't it be the !isWar() test that gets the extra condition added?

        if ( skip && !addContextWarDependencies )
        {
            getLog().info( "skip execution" );
            return;
        }
        // ensure project is a web application
        if ( !isWar() )
        {
            getLog().info( messagesProvider.getMessage( "AbstractRunMojo.nonWar" ) );
            return;
        }

should read:

        if ( skip )
        {
            getLog().info( "skip execution" );
            return;
        }
        // ensure project is a web application
        if ( !isWar() && !addContextWarDependencies )
        {
            getLog().info( messagesProvider.getMessage( "AbstractRunMojo.nonWar" ) );
            return;
        }

                
> "Skipping non-war project" should not happen if using <addContextWarDependencies>
> ---------------------------------------------------------------------------------
>
>                 Key: MTOMCAT-160
>                 URL: https://issues.apache.org/jira/browse/MTOMCAT-160
>             Project: Apache Tomcat Maven Plugin
>          Issue Type: Bug
>    Affects Versions: 1.1, 2.0-beta-1
>            Reporter: Neale Upstone
>            Assignee: Olivier Lamy (*$^¨%`£)
>             Fix For: 2.0
>
>
> For build pipelines, <addContextWarDependencies>true</addContextWarDependencies>
is often used in projects which contain just the acceptance tests.
> If the project packaging is set as JAR, we get:
> [INFO] [tomcat:run {execution: start-tomcat}]
> [INFO] Skipping non-war project
> I can see reasons why the skip logic is there, but this should not happen when addContextWarDependencies
(or any cleaner successor) is enabled.
> Any chance of this getting tweaked for beta2/rc1 ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message