tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1354847 - in /tomcat/trunk: java/javax/servlet/http/HttpServlet.java test/javax/servlet/http/ test/javax/servlet/http/TestHttpServlet.java test/org/apache/catalina/startup/TomcatBaseTest.java
Date Thu, 28 Jun 2012 08:16:07 GMT
On 28/06/2012 09:06, Konstantin Kolinko wrote:
> 2012/6/28  <markt@apache.org>:
>> Author: markt
>> Date: Thu Jun 28 07:55:13 2012
>> New Revision: 1354847
>>
>> URL: http://svn.apache.org/viewvc?rev=1354847&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53454
>> Return correct content-length header for HEAD requests when value is > 2GB
>>
>> Added:
>>    tomcat/trunk/test/javax/servlet/http/
>>    tomcat/trunk/test/javax/servlet/http/TestHttpServlet.java   (with props)
>> Modified:
>>    tomcat/trunk/java/javax/servlet/http/HttpServlet.java
>>    tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
> 
> 
> 1. Maybe use response.getHeader() method added in Servlet 3.0?

Because of the way we handle content-length, I don't think that will work.

> There is setIntHeader() method and add*Header methods.

Yep. I'll add some more checks.

> 2. Trunk needs an additional fix for Servlet 3.1,
> as there will be setContentLengthLong() method as was recently added to trunk.

This was intended for back-port. There are a number of changes needed to
trunk for setContentLengthLong() that I am currently working on.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message