tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: [VOTE] Release Apache Tomcat 7.0.28
Date Sat, 16 Jun 2012 09:04:47 GMT
On 15.06.2012 11:14, Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.28 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.28/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-243/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_28/
>
> The proposed 7.0.27 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.28 Stable

+1 to release

Most noteable observation: File conf/web.xml now is open 9 times in 
parallel (9 file descriptors), was 4 times in 7.0.27.

Details:

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag, except for the following minor points
   (no regression)
   - line ends of modules/jdbc-pool/resources/MANIFEST.MF differ
     between svn and gz although eol-style is set correctly.
   - the files we copy before building, e.g.
     catalina.properties and jdbc-pool.xml are of course
     not in svn for the cp target location, but they are
     in the src bundles.
- builds fine
- build result looks consistent with binaries
- no checkstyle complaints
- some Javadoc warnings (only in jdbc-pool, see below)
- Unit tests no failures, but some warnings (see below)
- JMX MBean-Comparison
   - some additional file descriptors, most prominent the file
     conf/web.xml was open in parallel 4 times for 7.0.27, now
     it is open in parallel 9 times (!) for 7.0.28.
   - tldScanTime went up for /docs from 7 to 53 (maybe not significant)
     and for /examples from 275 to 470 (but varies between 280 and 750)
   - Compression Filter filterInitParameterMap changed from
     {compressionThreshold=10, debug=0} to
     {compressionBuffer=8192, compressionThreshold=128,
      compressionMimeTypes=text/html,text/plain,text/xml, debug=0}
   - new expected attribute maxHeaderCount in ThreadPool,
     Connector and ProtocolHandler MBeans
   - new attribute connectionCount in ThreadPool MBeans
   - two additional daemon threads ("MessageSender[/examples]" and
     "SnakeWebSocketServlet Timer")

Build and tests were done using Java 1.6.0_30, OS was Solaris 10 Sparc,
tcnative was 1.1.24 based on APR 1.4.6 and OpenSSL 1.0.1c (plus two 
patches).

Javadoc Warnings in jdbc-pool:

   [javadoc] 
/shared/build/dev/tomcat/incoming/tc7.0.x/7.0.28/tmp-7.0.28/apache-tomcat-7.0.28-src-gz/output/dist/src/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java:544:

warning - Tag @link: can't find getParentLogger in javax.sql.DataSource
   [javadoc] 
/shared/build/dev/tomcat/incoming/tc7.0.x/7.0.28/tmp-7.0.28/apache-tomcat-7.0.28-src-gz/output/dist/src/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java:1294:

warning - @inheritDoc used but purge() does not override or implement 
any method.
   [javadoc] 
/shared/build/dev/tomcat/incoming/tc7.0.x/7.0.28/tmp-7.0.28/apache-tomcat-7.0.28-src-gz/output/dist/src/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java:1305:

warning - @inheritDoc used but purgeOnReturn() does not override or 
implement any method.
   [javadoc] 
/shared/build/dev/tomcat/incoming/tc7.0.x/7.0.28/tmp-7.0.28/apache-tomcat-7.0.28-src-gz/output/dist/src/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java:1294:

warning - @inheritDoc used but purge() does not override or implement 
any method.
   [javadoc] 
/shared/build/dev/tomcat/incoming/tc7.0.x/7.0.28/tmp-7.0.28/apache-tomcat-7.0.28-src-gz/output/dist/src/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java:1305:

warning - @inheritDoc used but purgeOnReturn() does not override or 
implement any method.
   [javadoc] 
/shared/build/dev/tomcat/incoming/tc7.0.x/7.0.28/tmp-7.0.28/apache-tomcat-7.0.28-src-gz/output/dist/src/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java:67:

warning - Tag @link: can't find isValid(boolean) in java.sql.Connection
   [javadoc] 
/shared/build/dev/tomcat/incoming/tc7.0.x/7.0.28/tmp-7.0.28/apache-tomcat-7.0.28-src-gz/output/dist/src/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java:1294:

warning - @inheritDoc used but purge() does not override or implement 
any method.
   [javadoc] 
/shared/build/dev/tomcat/incoming/tc7.0.x/7.0.28/tmp-7.0.28/apache-tomcat-7.0.28-src-gz/output/dist/src/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java:1305:

warning - @inheritDoc used but purgeOnReturn() does not override or 
implement any method.


Unit test warnings:

- org.apache.catalina.deploy.TestWebXmlOrdering
   - BIO, NIO and APR: [main] 
org.apache.catalina.deploy.WebXml.orderWebFragments Used a wrong 
fragment name z at web.xml absolute-ordering tag!

- org.apache.tomcat.util.net.TestCustomSsl
   - BIO twice "Exception getting SSL attributes"
   - NIO twice "WARNING: Exception re-negotiating SSL connection"

- tribes

   - BIO and NIO in 
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator:

org.apache.catalina.tribes.transport.nio.ParallelNioSender.doLoop Member 
send is failing for:tcp://{195, 227, 30, 235}:4006 ; Setting to suspect 
and retrying.
org.apache.catalina.tribes.transport.nio.ParallelNioSender.doLoop Member 
send is failing for:tcp://{195, 227, 30, 235}:4005 ; Setting to suspect 
and retrying.
org.apache.catalina.tribes.transport.nio.NioReceiver.listen Replication 
client disconnected, error when polling key. Ignoring client.

   - BIO, NIO and APR 6 times in 
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator:

org.apache.catalina.tribes.group.interceptors.NonBlockingCoordinator.sendElectionMsgToNextInline

Unable to send election message 
to:org.apache.catalina.tribes.membership.MemberImpl[tcp://{...}:...,{...},..., 
alive=..., securePort=-1, UDP Port=-1, id={... }, payload={}, 
command={...}, domain={...}, ]

   - Only APR in 
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator:

org.apache.catalina.tribes.transport.nio.NioReceiver.listen Replication 
client disconnected, error when polling key. Ignoring client.
org.apache.catalina.tribes.transport.nio.ParallelNioSender.doLoop Member 
send is failing for:tcp://{...}:...; Setting to suspect and retrying.
org.apache.catalina.tribes.transport.nio.ParallelNioSender.doLoop Member 
send is failing for:tcp://{...}:...; Setting to suspect and retrying.

   - BIO and APR in 
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector:

org.apache.catalina.tribes.transport.nio.NioReceiver.listen Replication 
client disconnected, error when polling key. Ignoring client.

   - NIO in 
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector:

org.apache.catalina.tribes.transport.nio.NioReplicationTask.run 
IOException in replication worker, unable to drain channel. Probable 
cause: Keep alive socket closed[null].

   - APR in org.apache.catalina.tribes.group.TestGroupChannelStartStop 
and org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor:

org.apache.catalina.tribes.transport.nio.NioReceiver.listen Replication 
client disconnected, error when polling key. Ignoring client.

   - BIO, NIO and APR 1-2 times in 
org.apache.catalina.startup.TestWebRuleSet:

IOException in replication worker, unable to drain channel. Probable 
cause: Keep alive socket closed[null].


Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message