Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9399EC803 for ; Sat, 12 May 2012 16:51:29 +0000 (UTC) Received: (qmail 53971 invoked by uid 500); 12 May 2012 16:51:28 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 53906 invoked by uid 500); 12 May 2012 16:51:28 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 53896 invoked by uid 99); 12 May 2012 16:51:28 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 May 2012 16:51:28 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 May 2012 16:51:25 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id CD72C23889BB for ; Sat, 12 May 2012 16:51:02 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1337591 - /tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Date: Sat, 12 May 2012 16:51:02 -0000 To: dev@tomcat.apache.org From: kkolinko@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120512165102.CD72C23889BB@eris.apache.org> Author: kkolinko Date: Sat May 12 16:51:02 2012 New Revision: 1337591 URL: http://svn.apache.org/viewvc?rev=1337591&view=rev Log: Followup to r1336516 Add Javadoc (as asked by sebb) and avoid looking up a volatile field twice Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java?rev=1337591&r1=1337590&r2=1337591&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Sat May 12 16:51:02 2012 @@ -174,9 +174,19 @@ public abstract class AbstractEndpoint { public int getMaxConnections() { return this.maxConnections; } + /** + * Return the current count of connections handled by this endpoint, if the + * connections are counted (which happens when the maximum count of + * connections is limited), or -1 if they are not. This + * property is added here so that this value can be inspected through JMX. + * It is visible on "ThreadPool" MBean. + * + * @return The count + */ public long getConnectionCount() { - if (connectionLimitLatch != null) { - return connectionLimitLatch.getCount(); + LimitLatch latch = connectionLimitLatch; + if (latch != null) { + return latch.getCount(); } return -1; } --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org