tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53180] New: DefaultInstanceManager#populateAnnotationsCache - incomplete check is used when validating for a setter method
Date Wed, 02 May 2012 20:27:25 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53180

          Priority: P2
            Bug ID: 53180
          Assignee: dev@tomcat.apache.org
           Summary: DefaultInstanceManager#populateAnnotationsCache -
                    incomplete check is used when validating for a setter
                    method
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: violetagg@apache.org
          Hardware: All
            Status: NEW
           Version: 7.0.27
         Component: Catalina
           Product: Tomcat 7

Created attachment 28711
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28711&action=edit
Patch proposal

Hi,

In org.apache.catalina.core.DefaultInstanceManager#populateAnnotationsCache,
when iterating over methods in a given class, in one of the cases (when
injection-target is specified) you validate whether the method is a valid
setter method. In my opinion the check that is used for that validation is not
complete.
I would like to propose a patch (attached) that introduces additional checks in
order to guarantee that the corresponding method is really suitable to be an
injection target.

I'm looking forward to your commends.

Best Regards
Violeta Georgieva

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message