tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: svn commit: r1333218 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml webapps/docs/config/http.xml
Date Thu, 03 May 2012 01:13:46 GMT
Filip,

On 5/2/12 5:33 PM, fhanik@apache.org wrote:
> Very hard for applications to see a performance benefit of more than 2 pollers

[...]

> -    protected int pollerThreadCount = Runtime.getRuntime().availableProcessors();
> +    protected int pollerThreadCount = Math.min(2,Runtime.getRuntime().availableProcessors());

I think you mean Math.max(). What you have is a minimum of 2 and a
maximum of the number of cores, which is exactly the opposite of what
your commit comment says is appropriate.

-chris


Mime
View raw message