tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filip Hanik \(mailing lists\)" <devli...@hanik.com>
Subject RE: svn commit: r1333218 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml webapps/docs/config/http.xml
Date Thu, 03 May 2012 02:06:44 GMT
Math.min is the intention here. On a 64 core box, it should still only have 2 pollers, not
64

The comment should read ('from' instead of 'of')

> > Very hard for applications to see a performance benefit *from* more than 2
> pollers

> -----Original Message-----
> From: Christopher Schultz [mailto:chris@christopherschultz.net]
> Sent: Wednesday, May 02, 2012 7:14 PM
> To: Tomcat Developers List
> Subject: Re: svn commit: r1333218 - in /tomcat/trunk:
> java/org/apache/tomcat/util/net/NioEndpoint.java
> webapps/docs/changelog.xml webapps/docs/config/http.xml
> 
> Filip,
> 
> On 5/2/12 5:33 PM, fhanik@apache.org wrote:
> > Very hard for applications to see a performance benefit of more than 2
> pollers
> 
> [...]
> 
> > -    protected int pollerThreadCount =
> Runtime.getRuntime().availableProcessors();
> > +    protected int pollerThreadCount =
> Math.min(2,Runtime.getRuntime().availableProcessors());
> 
> I think you mean Math.max(). What you have is a minimum of 2 and a
> maximum of the number of cores, which is exactly the opposite of what
> your commit comment says is appropriate.
> 
> -chris



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message