Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E5DC9185 for ; Mon, 23 Apr 2012 03:01:30 +0000 (UTC) Received: (qmail 20845 invoked by uid 500); 23 Apr 2012 03:01:29 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 20688 invoked by uid 500); 23 Apr 2012 03:01:29 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 20671 invoked by uid 99); 23 Apr 2012 03:01:29 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Apr 2012 03:01:29 +0000 Received: from localhost (HELO mail-wg0-f43.google.com) (127.0.0.1) (smtp-auth username kfujino, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Apr 2012 03:01:28 +0000 Received: by wgbdr12 with SMTP id dr12so9335893wgb.0 for ; Sun, 22 Apr 2012 20:01:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.180.81.166 with SMTP id b6mr17347828wiy.0.1335150087240; Sun, 22 Apr 2012 20:01:27 -0700 (PDT) Received: by 10.180.95.105 with HTTP; Sun, 22 Apr 2012 20:01:27 -0700 (PDT) In-Reply-To: References: <20120417062322.6BBA223889FD@eris.apache.org> Date: Mon, 23 Apr 2012 12:01:27 +0900 Message-ID: Subject: Re: svn commit: r1326941 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/session/ java/org/apache/catalina/tribes/tipis/ webapps/docs/ From: Keiichi Fujino To: Tomcat Developers List Content-Type: text/plain; charset=ISO-8859-1 2012/4/21 Konstantin Kolinko : > OK. > After a few days I think there is more to it: > > In case when (diffable == false, complete == true, isAccess == true), > I think "complete" has to take priority over "isAccess". > > I think that in that case it has to create MSG_BACKUP message. Does > that message replicate session access time? > > With the current code it creates MSG_ACCESS, because isAccess is checked first. The access time of an entry also seems to be replicated since entry value is overwritten in a backup node. Furthermore, in DeltaSession, access time is updated also by calling setOwner(). fixed it at r1329046. complete message takes priority over access message. Thanks for the review. -- Keiichi.Fujino --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org