Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.213.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4F7F605F.7090207@apache.org>
References: <20120406184420.1941F23889EC@eris.apache.org>
	<CABzHfV=1LbbvFDOk7st4q_GQ-oHeF_iB39UayO-2AiKaqUr5MA@mail.gmail.com>
	<4F7F605F.7090207@apache.org>
Date: Sat, 7 Apr 2012 01:34:47 +0400
Message-ID: 
 <CABzHfVmmUnA3oM7thghsgDY0sAMRiE1_+uR=bmO=REt7J0BY6g@mail.gmail.com>
Subject: Re: svn commit: r1310541 - in /tomcat/trunk/test/javax:
 el/TestCompositeELResolver.java servlet/jsp/TestPageContext.java
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2012/4/7 Mark Thomas <markt@apache.org>:
> On 06/04/2012 22:16, Konstantin Kolinko wrote:
>> 2012/4/6 =A0<markt@apache.org>:
>>> Author: markt
>>> Date: Fri Apr =A06 18:44:19 2012
>>> New Revision: 1310541
>>>
>>> URL: http://svn.apache.org/viewvc?rev=3D1310541&view=3Drev
>>> Log:
>>> Don't use static imports
>>
>> ?
>>
>> 1. I would say that I'd prefer to use static imports in JUnit tests.
>> They cause no confusion here and are easier to read
>>
>> (and using static imports for those assert methods is what is
>> recommended in many places).
>
> Having seen other projects avoid them and then compared the two styles I
> prefer not using them.

In general I'd also prefer not to use them, but JUnit tests are a
special exception where this usage is well-known.

I think we already discussed this (and thus are our checkstyle rules).

>> 2. It should be already allowed by configuration in checkstyle.xml,
>> so was there a problem?
>
> No problem. Just a personal itch.
>
> I was going to work my way through the remainder if nobody complained
> but I am happy to revert it if folks prefer the static imports.
>
>

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org