Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.161.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20120413191247.8C7A723889E3@eris.apache.org>
References: <20120413191247.8C7A723889E3@eris.apache.org>
Date: Sat, 14 Apr 2012 04:41:47 +0400
Message-ID: 
 <CABzHfV=Kr1dwjDK=DOe2kJnrqH0HcunuznEv1cxSE9y5TE=Diw@mail.gmail.com>
Subject: Re: svn commit: r1325908 -
 /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2012/4/13  <olamy@apache.org>:
> Author: olamy
> Date: Fri Apr 13 19:12:47 2012
> New Revision: 1325908
>
> URL: http://svn.apache.org/viewvc?rev=3D1325908&view=3Drev
> Log:
> document new filtering on context file
>
> Modified:
> =A0 =A0tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/a=
pache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
>
> Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/or=
g/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
> URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven=
-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRu=
nMojo.java?rev=3D1325908&r1=3D1325907&r2=3D1325908&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apac=
he/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java (original)
> +++ tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apac=
he/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java Fri Apr 13 19:12:47=
 2012
> @@ -305,7 +305,9 @@ public abstract class AbstractRunMojo
>
>
> =A0 =A0 /**
> - =A0 =A0 * The path of the Tomcat context XML file.
> + =A0 =A0 * <p>The path of the Tomcat context XML file.</p>
> + =A0 =A0 * <p>Prior to release 2.0, the file is filtering as a maven res=
ource so you can use
> + =A0 =A0 * interpolation tokens ${ }</p>

I do not understand the above wording.
You mean that "${ }" can be used starting with 2.0?

If yes then the sentence says quite the opposite.
It should be s/prior/since/  and s/is filtering/is filtered/.

If no then I'd note explicitly that "Since 2.0 you can no longer use ${}".


> =A0 =A0 =A0*
> =A0 =A0 =A0* @parameter expression=3D"${maven.tomcat.contextFile}"
> =A0 =A0 =A0*/
>
>

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org