tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik Mailing Lists <devli...@hanik.com>
Subject Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Date Wed, 04 Apr 2012 18:13:49 GMT


----- Original Message -----
> From: "Konstantin Kolinko" <knst.kolinko@gmail.com>
> To: "Tomcat Developers List" <dev@tomcat.apache.org>
> Sent: Wednesday, April 4, 2012 11:52:01 AM
> Subject: Re: svn commit: r1307093 -
> /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
> 
> 2012/4/4 Filip Hanik Mailing Lists <devlists@hanik.com>:
> >
> >
> > ----- Original Message -----
> >> From: "Mark Thomas" <markt@apache.org>
> >> To: "Tomcat Developers List" <dev@tomcat.apache.org>
> >> Sent: Wednesday, April 4, 2012 11:18:42 AM
> >> Subject: Re: svn commit: r1307093 -
> >> /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
> >>
> >> On 04/04/2012 17:12, Filip Hanik Mailing Lists wrote:
> >> >
> >> >
> >> > ----- Original Message -----
> >> >> From: markt@apache.org To: dev@tomcat.apache.org Sent:
> >> >> Thursday,
> >> >> March 29, 2012 2:19:18 PM Subject: svn commit: r1307093 -
> >> >> /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
> >> >>
> >> >>
> >> >>
> >> Author: markt
> >> >> Date: Thu Mar 29 20:19:18 2012 New Revision: 1307093
> >> >
> >> >> @Override -    public Object invoke(Object proxy, Method
> >> >> method,
> >> >> Object[] args) throws Throwable { +    public Object
> >> >> invoke(Object
> >> >> proxy, Method method, Object[] args) +            throws
> >> >> Throwable
> >> >> {
> >> >
> >> > Can we change the line length to something more modern than our
> >> > 1980s
> >> > monitors that were limited to 80 characters. In today's
> >> > environment,
> >> > 80 characters is like your chat window, surely we can go 120 or
> >> > 150
> >> > and get way more readable code
> >>
> >> If I was going to dedicate my whole screen to the code pane then
> >> yes,
> >
> > whole screen can probably fit 300+ characters, so were not talking
> > whole screen.
> > 80 is so tiny that it takes up a quarter of my screen or less.
> > I would therefor suggest to increase this, as it will dramatically
> > shrink the number of lines of code, and readability
> >
> 
> I know of two places where long lines cause problems:
> 
> 1. Commit e-mails.
> 
> Long lines are wrapped and it impacts readability.
> 
> 2. Side-by-side comparison in viewvc when you do "colored" comparison

here I see a challenge, since so many of our commits, are not code commits, but like a line
wrap commit like this,
this pollutes our diffs and why I'm not a big fan of changing it for changing it.

> 
> 
> Therefore I would like to stick to the current convention of 80
> chars.
> It is not a hard convention (we do not enforce it through
> checkstyle),
> but something to follow.

The "convention" is something fairly new. For most of the time of Tomcat's life time, it was
the committers preference, but fairly recently is when we started modifying style for style's
sake. So the archives you refer to, can't go that far back. The only convention we've had
through the history of Tomcat, is spaces, not tabs, not line length etc.

> 
> There should be several previous discussions on this topic in the
> archives...




> 
> 
> Best regards,
> Konstantin Kolinko
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message