tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 52791] [PATCH] read windows installer default values from config file
Date Wed, 04 Apr 2012 18:58:31 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52791

Sandra Madden <smadden@vocera.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28399|0                           |1
        is obsolete|                            |

--- Comment #3 from Sandra Madden <smadden@vocera.com> 2012-04-04 18:58:31 UTC ---
Created attachment 28543
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=28543
Rev2 of the patch to add config file support. Incorporated changes suggested by
Konstantin Kolinko

Thanks for the constructive feedback Konstantin. I changed the patch to only
read the ini file when it is passed in on the cmdline as /C=<fully qualified
path to filename>.

I also improved the way the macro/function hybrid to read the values is
written. I initially based it on sample code I found online, but now cleaned it
all up to have less clutter and match the needs of the tomcat installer better. 

The patch is still not reading in the config file at once and parse it from
memory. I wanted to keep using the established macro ${ConfigRead} instead of
writing something new to minimize possible introduction of bugs.

-Sandra

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message