tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 52791] [PATCH] read windows installer default values from config file
Date Tue, 03 Apr 2012 20:40:29 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52791

Konstantin Kolinko <knst.kolinko@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|                            |All

--- Comment #2 from Konstantin Kolinko <knst.kolinko@gmail.com> 2012-04-03 20:40:29
UTC ---
-1 for hard-coded filename of "config.ini".

IMHO the name of the answer file should be passed on the command line. If no
name is given then there should be no attempts to open and read the file.


(Is is possible to read the file just once, instead of re-opening and
re-scanning it for each config option?  It is not as bad if this behaviour is
off by default. it is just that it does not scale well.  Maybe read the file
into memory and do string scans there?)

The names: _Call, _String, _Result, _Default -- are you sure that they are
unique? They look like polluting the name space.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message