tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Grotzke <martin.grot...@googlemail.com>
Subject fireRequestDestroyEvent now fired by StandardHostValve instead of StandardContextValve
Date Wed, 18 Apr 2012 15:03:49 GMT
Hi,

in r1164481 the notification of ServletRequestListeners was moved from
StandardContextValve to StandardHostValve.

This causes issues for memcached-session-manager (msm) in combination
with openwebbeans (OWB).

In short, msm is an alternative session manager that uses memcached as
for session storage. It uses a valve to track the start/end of a
request, at the end of the request (at the end of valve.invoke) msm
stores the session in memcached.

OWB uses a ServletRequestListener to prepare the session for failover
support on requestDestroyed.

With the change in tomcat (r1164481), OWB does no longer work with msm,
as the ServletRequestListener is now invoked by StandardHostValve
*after* msm has already writted the session to memcached - so the
changes by OWB are lost.

This is the issue in the OWB issue tracker btw:
https://issues.apache.org/jira/browse/OWB-646

AFAIU the commit message it's completely intended that StandardHostValve
now invokes StandardContext.fireRequestDestroyEvent.
So I assume you're not going to change this again - or do you see
alternative solutions for the problem that should be solved by this change?

Assuming that you're not going to change StandardHostValve, what would
you suggest how to integrate msm and OWB properly?

Thanx in advance,
cheers,
Martin




Mime
View raw message