tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1310541 - in /tomcat/trunk/test/javax: el/TestCompositeELResolver.java servlet/jsp/TestPageContext.java
Date Fri, 06 Apr 2012 21:30:07 GMT
On 06/04/2012 22:16, Konstantin Kolinko wrote:
> 2012/4/6  <markt@apache.org>:
>> Author: markt
>> Date: Fri Apr  6 18:44:19 2012
>> New Revision: 1310541
>>
>> URL: http://svn.apache.org/viewvc?rev=1310541&view=rev
>> Log:
>> Don't use static imports
> 
> ?
> 
> 1. I would say that I'd prefer to use static imports in JUnit tests.
> They cause no confusion here and are easier to read
> 
> (and using static imports for those assert methods is what is
> recommended in many places).

Having seen other projects avoid them and then compared the two styles I
prefer not using them.

> 2. It should be already allowed by configuration in checkstyle.xml,
> so was there a problem?

No problem. Just a personal itch.

I was going to work my way through the remainder if nobody complained
but I am happy to revert it if folks prefer the static imports.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message