tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik Mailing Lists <devli...@hanik.com>
Subject Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Date Wed, 04 Apr 2012 17:39:09 GMT


----- Original Message -----
> From: "Mark Thomas" <markt@apache.org>
> To: "Tomcat Developers List" <dev@tomcat.apache.org>
> Sent: Wednesday, April 4, 2012 11:18:42 AM
> Subject: Re: svn commit: r1307093 -
> /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
> 
> On 04/04/2012 17:12, Filip Hanik Mailing Lists wrote:
> > 
> > 
> > ----- Original Message -----
> >> From: markt@apache.org To: dev@tomcat.apache.org Sent: Thursday,
> >> March 29, 2012 2:19:18 PM Subject: svn commit: r1307093 -
> >> /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
> >>
> >>
> >> 
> Author: markt
> >> Date: Thu Mar 29 20:19:18 2012 New Revision: 1307093
> > 
> >> @Override -    public Object invoke(Object proxy, Method method,
> >> Object[] args) throws Throwable { +    public Object invoke(Object
> >> proxy, Method method, Object[] args) +            throws Throwable
> >> {
> > 
> > Can we change the line length to something more modern than our
> > 1980s
> > monitors that were limited to 80 characters. In today's
> > environment,
> > 80 characters is like your chat window, surely we can go 120 or 150
> > and get way more readable code
> 
> If I was going to dedicate my whole screen to the code pane then yes,

whole screen can probably fit 300+ characters, so were not talking whole screen.
80 is so tiny that it takes up a quarter of my screen or less.
I would therefor suggest to increase this, as it will dramatically shrink the number of lines
of code, and readability


> but there are other useful panes I want to see as well. 80 chars is
> about right for the code window (and the line length we generally
> stick
> to throughout the Tomcat code base).
> 
> Mark
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message