tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filip Hanik \(mailing lists\)" <devli...@hanik.com>
Subject RE: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
Date Thu, 05 Apr 2012 19:12:40 GMT


> -----Original Message-----
> From: Konstantin Kolinko [mailto:knst.kolinko@gmail.com]
> Sent: Wednesday, April 04, 2012 2:34 PM
> To: Tomcat Developers List
> Subject: Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-
> pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacad
> e.java
> 
> 2012/4/4 Filip Hanik Mailing Lists <devlists@hanik.com>:
> >>
> >> I know of two places where long lines cause problems:
> >>
> >> 1. Commit e-mails.
> >>
> >> Long lines are wrapped and it impacts readability.
> >>
> >> 2. Side-by-side comparison in viewvc when you do "colored" comparison
> >
> > here I see a challenge, since so many of our commits, are not code
> commits, but like a line wrap commit like this,
> > this pollutes our diffs and why I'm not a big fan of changing it for
> changing it.
> 
> I do not remember many line-wrap commits.
[Filip Hanik] 
You're looking at the reply of one.

> There are ending whitespace commits, because sometimes people forget
> to run checkstyle and we would be nagged if someone does not fix the
> code.
> 
> 
> >> Therefore I would like to stick to the current convention of 80
> >> chars.
> >> It is not a hard convention (we do not enforce it through
> >> checkstyle),
> >> but something to follow.
> >
> > The "convention" is something fairly new. For most of the time of
> Tomcat's life time, it was the committers preference, but fairly
> recently is when we started modifying style for style's sake. So the
> archives you refer to, can't go that far back. The only convention we've
> had through the history of Tomcat, is spaces, not tabs, not line length
> etc.
> 
> a. I might be not very careful in selecting English words. Please excuse
> me.
> 
> b. I do not see much difference between "convention" and "preference".
[Filip Hanik] 
Convention = mutually agreed upon standard
Preference = Individual standard, like I like 120, markt likes 80

> If it is a preference of many then it has to be respected as a
> convention. Isn't it?
[Filip Hanik] 
Not really, only if it is mutually agreed upon
> 
> 
> Previous discussion (December 2010):
> http://markmail.org/thread/alo77qd4yiduvqvz
[Filip Hanik] 
Opinions in this thread as I read it is
 - 80 is a bit outdated
 - 80 is not enforced

> 
> We also have this description of our coding style:
> http://tomcat.apache.org/getinvolved.html#Coding_Conventions
[Filip Hanik] 
Again, I'm only bringing this up for the following reasons
 - I think we can modernize our preferences/conventions/standards
 - If we are gonna enforce something like that, let's automate it a bit more

Now, since only three people have chimed in, you, me and Mark, and both you
and Mark believe that 80 is good for now, then we should aim for it, but as
the thread points out, not enforced.

I'll bring it up in another year or so, when monitors are even better :)

Filip

> 
> 
> Best regards,
> Konstantin Kolinko
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message