tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51181] Add support for Web Sockets
Date Fri, 02 Mar 2012 19:10:05 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181

--- Comment #50 from Mark Thomas <markt@apache.org> 2012-03-02 19:10:05 UTC ---
(In reply to comment #49)
> Created attachment 28411 [details]
> Overrides for connection open and close

Patch applied (with some minor tweaks). Many thanks.

I can see this evolving over time. We may need to change this to an approach
(particularly for close) where the method intended to be overridden actually
does the work and the developer has to call super.onClose() at an appropriate
point. Alternatively, the can not call super.close() and take responsibility
for sending the close message themselves. However, we can hold off on that
refactoring until someone indicates they need it.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message