tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: svn commit: r1298288 - /tomcat/jk/trunk/native/buildconf.sh
Date Thu, 08 Mar 2012 12:14:41 GMT
On 03/08/2012 12:59 PM, Rainer Jung wrote:
> On 08.03.2012 12:06, Mladen Turk wrote:
>> On 03/08/2012 09:21 AM, Rainer Jung wrote:
>>> On 08.03.2012 09:08, Mladen Turk wrote:
>>>> On 03/08/2012 09:02 AM, rjung@apache.org wrote:
>>>>> Author: rjung
>>>>> Date: Thu Mar 8 08:02:45 2012
>>>>> New Revision: 1298288
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1298288&view=rev
>>>>> Log:
>>>>> Remove "--force" from libtoolize in buildconf
>>>>> to prevent overwrite of our config.(guess|sub)
>>>>> copies with system installed ones.
>>>>>
>>>>
>>>> Think that doesn't cause to overwrite config files only libtool ones.
>>>
>>> I'm pretty sure it does overwrite them and that's why I removed it
>>> from APR buildconf long ago,
>>
>> I tried on linux and solaris and libtoolize --force doesn't overwrite
>> the config.sub file. config.sub files are overwritten by
>> automake's --force-missing (and that's now removed)
>>
>> libtoolize --force will only overwrite ltmain.sh
>
> Hmmm: my libtoolize contains calls to
>
> func_config_update config.guess ...
> func_config_update config.sub ...
>
> which results in
>
> func_config_update -> func_keyword_update
>
> which contains
>
> if $my_keyword_update_p || $opt_force; then
> func_copy "$my_srcfile" "$my_destfile" "$my_msg_var"
>
> ?
>

Well my libtoolize says in main
# Do not remove config.guess nor config.sub, we don't install them
# without --install, and the project may not be using Automake.

So you need to pass --install AND --force so they get overwritten
Anyhow, the easiest way is to actually test it :)


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message